[ENG-6719] Show Funder and Grant ID information on registries moderation cards #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsemets
requested changes
Jan 19, 2026
Comment on lines
186
to
188
| catchError((error) => { | ||
| return handleSectionError(ctx, 'submissions', error); | ||
| }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| catchError((error) => { | |
| return handleSectionError(ctx, 'submissions', error); | |
| }) | |
| catchError((error) => handleSectionError(ctx, 'submissions', error)) |
|
|
||
| return this.metadataService.getCustomItemMetadata(registryId).pipe( | ||
| tap((res) => { | ||
| const newFunders = res.funders; |
Comment on lines
178
to
180
| patch({ | ||
| funders: newFunders, | ||
| }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| patch({ | |
| funders: newFunders, | |
| }) | |
| patch({ funders: res.funders }) |
Comment on lines
72
to
75
| handleOpen() { | ||
| this.loadContributors.emit(); | ||
| this.loadRegistrySubmissionFunders.emit(); | ||
| } |
Collaborator
There was a problem hiding this comment.
It is better to have one emit: this.loadAdditionalData.emit().
nsemets
reviewed
Jan 20, 2026
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [FunderAwardsListComponent, TranslateModule.forRoot()], |
Collaborator
There was a problem hiding this comment.
Remove TranslateModule.forRoot(). It is legacy code for modules. We are using standalone components. Use OSFTestingModule.
Comment on lines
+16
to
+33
| const MOCK_FUNDERS: Funder[] = [ | ||
| { | ||
| funderName: 'National Science Foundation', | ||
| awardNumber: 'NSF-2024-X', | ||
| funderIdentifier: '10.13039/100000001', | ||
| funderIdentifierType: 'Crossref Funder ID', | ||
| awardUri: 'https://nsf.gov/award/1', | ||
| awardTitle: 'Advanced Research Initiative', | ||
| }, | ||
| { | ||
| funderName: 'European Research Council', | ||
| awardNumber: 'ERC-888', | ||
| funderIdentifier: '10.13039/501100000781', | ||
| funderIdentifierType: 'Crossref Funder ID', | ||
| awardUri: 'https://erc.europa.eu/award/2', | ||
| awardTitle: 'Future Fellowship', | ||
| }, | ||
| ]; |
Collaborator
There was a problem hiding this comment.
We already have mocks for it in testing. Use MOCK_FUNDERS import.
import { MOCK_FUNDERS } from '@testing/mocks/funder.mock';
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Some registries members use funder information to determine priority or relevance of submissions. They currently must drill down several layers within their moderation workflow to find this information.
Summary of Changes
Screenshot(s)
5ed4-290b-4e53-98a8-2db063551b9c.mp4
Side Effects
QA Notes